Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] the run-if condition for the rocm e2e tests job #56074

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

jstourac
Copy link
Contributor

Having the || means that even empty string is matched which results to this job being triggered everytime with any change to the repository.

Having the `||` means that even empty string is matched which results to
this job being triggered everytime with any change to the repository.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2024
@jstourac
Copy link
Contributor Author

jstourac commented Aug 29, 2024

@jiridanek @harshad16 @atheo89 please check, I don't have rights to add you as reviewers, thanks!

edit: okay, it's done automatically by the bot, so sorry for bugging.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jstourac: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-notebooks-main-rocm-notebooks-e2e-tests opendatahub-io/notebooks presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jiridanek
Copy link
Member

or like this

/assign @jiridanek @harshad16 @atheo89

@jiridanek
Copy link
Member

jiridanek commented Aug 29, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024
Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek
Copy link
Member

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@jiridanek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 29, 2024
Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

@jstourac: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3305ef7 into openshift:master Aug 29, 2024
17 checks passed
@jstourac jstourac deleted the fixRunIfRocm branch August 29, 2024 07:06
MiguelCarpio pushed a commit to MiguelCarpio/release that referenced this pull request Sep 4, 2024
Having the `||` means that even empty string is matched which results to
this job being triggered everytime with any change to the repository.
giladravid16 pushed a commit to giladravid16/release that referenced this pull request Sep 5, 2024
Having the `||` means that even empty string is matched which results to
this job being triggered everytime with any change to the repository.
MiguelCarpio pushed a commit to MiguelCarpio/release that referenced this pull request Sep 12, 2024
Having the `||` means that even empty string is matched which results to
this job being triggered everytime with any change to the repository.
obochan-rh pushed a commit to obochan-rh/release that referenced this pull request Sep 24, 2024
Having the `||` means that even empty string is matched which results to
this job being triggered everytime with any change to the repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants